Prevent SSL related fields from being sent empty to the Fastly API. #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/tls-bug
branch
from
104ee3f
to
5257323
Compare
doramatadora
approved these changes
Nov 28, 2022
| @@ -171,6 +171,10 @@ func TestAccFastlyServiceVCLBackend_basic(t *testing.T) { | |||
| backendName := fmt.Sprintf("backend-tf-%s", acctest.RandString(10)) | |||
| backendAddress := "httpbin.org" | |||
|
|
|||
| // The following backends are what we expect to exist after all our Terraform | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: While updating all the SSL fields for a backend to not be sent empty to the API (unless the user explicitly set them to be empty) I noticed that setting
use_sslwould cause an API error...To fix this you have to also specify
ssl_cert_hostname, so I've updated the tests to reflect this.