ci: validate interface not broken #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/validate-interface
branch
5 times, most recently
from
8af4033
to
3535b33
Compare
Integralist
force-pushed
the
integralist/validate-interface
branch
from
3535b33
to
b883953
Compare
Integralist
force-pushed
the
integralist/validate-interface
branch
from
20643d4
to
e6bca0d
Compare
Integralist
force-pushed
the
integralist/validate-interface
branch
from
e6bca0d
to
3509d1f
Compare
Integralist
force-pushed
the
integralist/validate-interface
branch
from
74480f9
to
ab4fdfa
Compare
Integralist
force-pushed
the
integralist/validate-interface
branch
from
ab4fdfa
to
ac69700
Compare
razaj92
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Breaking interface changes have still managed to be released.
Solution: Setup a CI validation step that compares plan output between latest release and proposed changes.
Notes:
breaking-changelabel will skipvalidate-interfacejob (as we expect it to fail).I confirmed the new validation job was working as intended by committing a breaking interface change to both the
backendanddomainimplementations, and then checking that the CI job failed (I've, of course, since reverted those breaking interface changes as they were only made to validate the new CI job).