fix: use paginator to fetch all ACL entries #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested changes
Sep 18, 2023
There was a problem hiding this comment.
👋🏻 Thank you so much for opening this PR (it's very much appreciated).
Just one minor test issue to fix and this will be good to go.
Don't worry about the CI job "validate-interface" failing. It's because forks do not get access to GitHub Action secrets (i.e. the API token required by that job). I've run that particular job locally and it's passing.
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Integralist
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #757
I think this should fix the issue above. I'm a Go newbie so happy to get any early feedback.
The acceptance tests still need to be run against this PR.