-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fastly_alert): implement resource and documentation #810
Conversation
👋🏻 You'll need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this and the go-fastly changes!
Small comment added
|
||
### Read-Only | ||
|
||
- `id` (String) The ID of this resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darin-nee There is also object
= "definition" that is returned in the response, also read-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's in the API response and elided in the Terraform schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, looked like I had a comment from 5 days ago sitting as "pending" 😬
fastly/resource_fastly_alert.go
Outdated
"description": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "Text body included in Alert notifications.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kinda read weird. Can we make these descriptions align (where possible) with the API docs?
For example...
Description: "Text body included in Alert notifications.", | |
Description: "Additional text that is included in the alert notification.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, done.
Would also be good to get this added to https://github.com/fastly/terraform-provider-fastly/blob/main/tests/interface/main.tf EDIT: See https://github.com/fastly/terraform-provider-fastly/blob/main/tests/interface/README.md |
41d82e1
to
5306e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is always a pleasure reviewing your PRs 👍🏻 You write good, clean code and 99% of the time you just get it "right" the first time. Well done and thanks for making it easy to review 🙂
Thanks @Integralist , and thanks for the review! |
…recognized in current provider version
This PR implements a new
fastly_alert
resource.