feat(fastly_alert): implement resource and documentation #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏻 You'll need to run |
|
|
||
| ### Read-Only | ||
|
|
||
| - `id` (String) The ID of this resource. |
There was a problem hiding this comment.
@darin-nee There is also object = "definition" that is returned in the response, also read-only
There was a problem hiding this comment.
Yep, that's in the API response and elided in the Terraform schema.
darin-nee
changed the title
Integralist
reviewed
Feb 13, 2024
fastly/resource_fastly_alert.go
Outdated
| "description": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "Text body included in Alert notifications.", |
There was a problem hiding this comment.
This kinda read weird. Can we make these descriptions align (where possible) with the API docs?
For example...
Suggested change
| Description: "Text body included in Alert notifications.", | |
| Description: "Additional text that is included in the alert notification.", |
|
Would also be good to get this added to https://github.com/fastly/terraform-provider-fastly/blob/main/tests/interface/main.tf EDIT: See https://github.com/fastly/terraform-provider-fastly/blob/main/tests/interface/README.md |
darin-nee
force-pushed
the
darin-nee/fastly-alerts
branch
from
41d82e1
to
5306e92
Compare
Integralist
approved these changes
Feb 14, 2024
|
Thanks @Integralist , and thanks for the review! |
…recognized in current provider version
Integralist
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
fastly_alertresource.