-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tls_subscription): ensure configuration_id is current value (not initial) #824
Conversation
403c753
to
a1e4936
Compare
@Integralist Any chance we could get this reviewed and hopefully merged in a new release? Thanks! |
Thanks @virgofx for your patience. I'm reviewing this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not going to merge immediately, as I would like a member of the Fastly TLS team to take a pass over my review just to sanity check some of my understanding around activation objects.
Thanks for the review. All suggestions look great, updating... |
Latest changes incorporated. Additionally, re-tested locally and confirmed the sort was specified correctly. |
9793507
to
fb9e1d0
Compare
Thanks @virgofx for your work on this PR. I'm not going to publish a new release just yet as I have a couple of other TF tasks I'm looking into at the moment. But hopefully very soon. |
The TLS configuration ID returned by the API is the initial TLS configuration when first activated. Instead, this value should represent the current TLS configuration id which can be found via the following API call.
https://api.fastly.com/tls/domains?filter[tls_certificates.id]={cert-id}&include=tls_activations
go fmt