fix(tls_subscription): ensure configuration_id is current value (not initial) #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgofx
force-pushed
the
mark/fix-787
branch
3 times, most recently
from
403c753
to
a1e4936
Compare
|
@Integralist Any chance we could get this reviewed and hopefully merged in a new release? Thanks! |
|
Thanks @virgofx for your patience. I'm reviewing this today. |
Integralist
approved these changes
Apr 8, 2024
|
Thanks for the review. All suggestions look great, updating... |
|
Latest changes incorporated. Additionally, re-tested locally and confirmed the sort was specified correctly. |
virgofx
force-pushed
the
mark/fix-787
branch
2 times, most recently
from
9793507
to
fb9e1d0
Compare
virgofx
commented
Apr 8, 2024
Integralist
approved these changes
Apr 9, 2024
|
Thanks @virgofx for your work on this PR. I'm not going to publish a new release just yet as I have a couple of other TF tasks I'm looking into at the moment. But hopefully very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS configuration ID returned by the API is the initial TLS configuration when first activated. Instead, this value should represent the current TLS configuration id which can be found via the following API call.
https://api.fastly.com/tls/domains?filter[tls_certificates.id]={cert-id}&include=tls_activations
go fmt