fix: update the default timeout value for healthcheck consistency with Fastly App (UI) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently timeout value for healthcheck is inconsistent with Fastly App (it's by default 5000ms in Fastly App source, while with terraform it's set to 500). This PR addresses this issue. Although It's not a burning issue (ie there is a workaround for this - just by explicitly setting timeout value user can work around), given it's pretty much common to implicitly set value upon managing resources through Terraform, this could be easily a pitfall for developers who are familiar with Fastly/VCL. Also, with just a 500ms timeuout, it's possible that healthcheck request configured with this default timeout value will just fail depending on where and how this healthcheck will be done.
Fixes #825.