fix(tls_mutual_authentication): update activation after mtls creation #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
changed the title
|
From a TLS perspective, the examples and basic usage all made sense. I'm unfamiliar with TF but got the gist of including the PATCH activation call within the mutual_authentication resource |
Integralist
force-pushed
the
integralist/fix-mtls
branch
5 times, most recently
from
a2706cc
to
b804f54
Compare
Integralist
force-pushed
the
integralist/fix-mtls
branch
from
b804f54
to
d39195f
Compare
razaj92
approved these changes
Apr 11, 2024
bryangm
approved these changes
Apr 11, 2024
Integralist
force-pushed
the
integralist/fix-mtls
branch
from
bce7e3f
to
d07c99f
Compare
…time value for subscription certificate_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
fastly_tls_mutual_authentication.There are two steps to setting up mTLS:
POST /tls/mutual_authenticationsPATCH /tls/activations/tls_activation_idThe original implementation was missing the second part.