Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying location when creating KV stores #834

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Add support for specifying location when creating KV stores #834

merged 8 commits into from
Apr 18, 2024

Conversation

hrmsk66
Copy link
Contributor

@hrmsk66 hrmsk66 commented Apr 17, 2024

👋 This PR adds the ability to specify the location when creating a new KV store using Terraform.

Changes made:

  • Update go-fastly to 9.3.0
  • Add a new location field to the fastly_kvstore resource.
  • Add a new acceptance test TestAccFastlyKVStore_WithLocation_validate and associated helper functions.
  • Updated the document with the additional field.

@Integralist Integralist added the enhancement New feature or request label Apr 17, 2024
Integralist
Integralist reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, otherwise looks good 👍🏻

fastly/resource_fastly_kvstore.go Outdated Show resolved Hide resolved
fastly/resource_fastly_kvstore.go Outdated Show resolved Hide resolved
fastly/resource_fastly_kvstore.go Outdated Show resolved Hide resolved
fastly/resource_fastly_kvstore_test.go Show resolved Hide resolved
Integralist
Integralist approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a TODO: note into the code for future reference.

@Integralist
Copy link
Collaborator

/ok-to-test sha=ecc85149ae89ebec03e992cfa1aae55d9602b476

@Integralist Integralist merged commit 9d6825f into fastly:main Apr 18, 2024
9 checks passed
@hrmsk66 hrmsk66 deleted the hrmsk66/add-location-to-create-kv-store branch April 18, 2024 09:27
@hrmsk66
Copy link
Contributor Author

hrmsk66 commented Apr 18, 2024

Thank you 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrmsk66 @Integralist