-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fastly_alerts): add percentage alerts #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But there are some minor requested changes...
/ok-to-test sha=330024a UPDATE: The |
266b6ca
to
cc9ff3d
Compare
cc9ff3d
to
42fbe72
Compare
https://pkg.go.dev/github.com/bflad/tfproviderlint@v0.29.0/passes/AT003 So I think we can just add a single underscore like so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did you have any other changes or is this ready to merge?
Ready to merge! |
This pull requests add tests and documentation about how to use a percentage alerts.