feat(fastly_alerts): add percentage alerts #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonroy-fastly
changed the title
Integralist
requested changes
May 7, 2024
|
/ok-to-test sha=330024a UPDATE: The |
jsonroy-fastly
force-pushed
the
percent-alerts
branch
from
266b6ca
to
cc9ff3d
Compare
jsonroy-fastly
force-pushed
the
percent-alerts
branch
from
cc9ff3d
to
42fbe72
Compare
|
Sigh. Terraform. So yeah it seems that Terraform has a thing where it expects one underscore between 
|
|
https://pkg.go.dev/github.com/bflad/tfproviderlint@v0.29.0/passes/AT003 So I think we can just add a single underscore like so |
darin-nee
reviewed
May 7, 2024
Integralist
approved these changes
May 8, 2024
|
Ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests add tests and documentation about how to use a percentage alerts.