Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): make service_id attribute optional #852

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

jsonroy-fastly
Copy link
Contributor

The PR aims to rectify the terraform definition of an alert when we configure an account aggregate alert.
The service_id on alerts is now optional when we configure an alerts on the stats source.

Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Integralist Integralist merged commit e4c1f63 into fastly:main Jun 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants