fix(tls_activation): update mutual_authentication_id #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
approved these changes
Jun 24, 2024
kpfleming
force-pushed
the
integralist/mtls
branch
from
ef22e2c
to
8bd6c7c
Compare
|
While it would be great to have an acceptance test which covers this, we don't have time for that at the moment so I'll create an issue to remember that we need to add it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #860
Note
I've taken the liberty of adding more nil dereference checks around the existing logic, as I wasn't comfortable with how the current code was just blindly trusting the pointers would contain an actual reference 😬