Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the entire data bundle and versioning all datasets based on the module name, version them individually. To do so, pull from the release and DOIs in https://github.com/fatiando-data instead of https://github.com/fatiando/data This means that functions won't have to be repeated and updating 1 dataset doesn't mean copying all of the others along with it (since the collection would be new). Versions are now specified as a required
version
argument in allfetch_*
functions.The implementation still bundles information for all v1 datasets in a variable to make it easier to manage. When updating a dataset, entries for the others don't need to be repeated. Also only need 2 environment variables for setting the cache location and the data source (instead of 2 per version). A downside is that we can no longer accept a variable to set custom data source URL since each dataset has a different one. The new environment variable only sets fetching from GitHub or not.
Reminders:
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
and the base__init__.py
file for the package.AUTHORS.md
file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.