Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository link to Lightning Creek data #40

Merged
merged 12 commits into from
Oct 21, 2022
Merged

Add repository link to Lightning Creek data #40

merged 12 commits into from
Oct 21, 2022

Conversation

MGomezN
Copy link
Member

@MGomezN MGomezN commented Sep 23, 2022

Add a pre-processing link for lightning-creek-magnetic.py

Relevant issues/PRs:

First step towards #39

Add a pre-processing link for lightning-creek-magnetic.py as requested in #39
@welcome
Copy link

welcome bot commented Sep 23, 2022

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

@leouieda
Copy link
Member

leouieda commented Oct 6, 2022

Hey @MGomezN just checking in here 👋🏾. Let know when you're ready or need any help with this.

@leouieda
Copy link
Member

leouieda commented Oct 6, 2022

@MGomezN could you please also add that to the function docstring here: https://github.com/fatiando/ensaio/blob/main/ensaio/_fetchers.py#L605

Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MGomezN made a small change to the link text to make it more generic so we can copy the same thing into the other datasets as well. I also fixed the formatting in the gallery which much be rst instead of md.

ensaio/_fetchers.py Outdated Show resolved Hide resolved
doc/gallery_src/lightning-creek-magnetic.py Outdated Show resolved Hide resolved
@leouieda leouieda changed the title Add pre-processing link Add repository link to Lightning Creek data Oct 21, 2022
@leouieda
Copy link
Member

leouieda commented Oct 21, 2022

@MGomezN for reference, this check was failing after I merged in the suggestions I made through github: https://github.com/fatiando/ensaio/actions/runs/3298037710/jobs/5439631739#step:6:9

Run make flake8
flake8 ensaio doc tools
doc/gallery_src/lightning-creek-magnetic.py:21:29: W291 trailing whitespace

flake8 is a tool we use to check the style of the code for common mistakes and consistency. One of those checks is making sure lines of code or documentation don't have a trailing white space at the end. When I code on my computer, I setup my editor to automatically remove these when I save a file. But on GitHub, it didn't do that so the check caught it. To fix this, I went into line 21 of the that file and deleted the whitespace at the end of the line. See this commit: 16077a4

@leouieda leouieda merged commit 9adfc63 into fatiando:main Oct 21, 2022
@welcome
Copy link

welcome bot commented Oct 21, 2022

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda
Copy link
Member

Merged! 🎉 Please add yourself to the AUTHORS.md file. Thanks for the help with this @MGomezN! Hope it was a useful learning experience.

@MGomezN
Copy link
Member Author

MGomezN commented Oct 29, 2022

Oh, Leo! It was a helpful learning experience for me, but for you, OMG, it was more like a nightmare-Halloween experience, didn't it? It takes 10x times as to fix my mistakes than do it yourself. But you are a committed teacher, and I appreciate that. I will do it better next time!

@leouieda
Copy link
Member

leouieda commented Nov 1, 2022

Not at all 🙂 Sure, I could have done it faster but I also have little time to spare and won't be around forever. So it's a selfish investment to teach you so I don't have to do things in the future 😬 My goal is to eventually sit back at the beach and watch Fatiando run itself 🍹

@MGomezN
Copy link
Member Author

MGomezN commented Nov 3, 2022

My goal is to eventually sit back at the beach and watch Fatiando run itself

Mmm that's exactly what I'm doing right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants