-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repository link to Lightning Creek data #40
Conversation
Add a pre-processing link for lightning-creek-magnetic.py as requested in #39
💖 Thank you for opening your first pull request in this repository! 💖 A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐ |
Hey @MGomezN just checking in here 👋🏾. Let know when you're ready or need any help with this. |
@MGomezN could you please also add that to the function docstring here: https://github.com/fatiando/ensaio/blob/main/ensaio/_fetchers.py#L605 |
Include pre-processing link to the function docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MGomezN made a small change to the link text to make it more generic so we can copy the same thing into the other datasets as well. I also fixed the formatting in the gallery which much be rst instead of md.
@MGomezN for reference, this check was failing after I merged in the suggestions I made through github: https://github.com/fatiando/ensaio/actions/runs/3298037710/jobs/5439631739#step:6:9
|
🎉 Congrats on merging your first pull request and welcome to the team! 🎉 If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved. |
Merged! 🎉 Please add yourself to the |
Oh, Leo! It was a helpful learning experience for me, but for you, OMG, it was more like a nightmare-Halloween experience, didn't it? It takes 10x times as to fix my mistakes than do it yourself. But you are a committed teacher, and I appreciate that. I will do it better next time! |
Not at all 🙂 Sure, I could have done it faster but I also have little time to spare and won't be around forever. So it's a selfish investment to teach you so I don't have to do things in the future 😬 My goal is to eventually sit back at the beach and watch Fatiando run itself 🍹 |
Mmm that's exactly what I'm doing right now :) |
Add a pre-processing link for lightning-creek-magnetic.py
Relevant issues/PRs:
First step towards #39