-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace conda for pip on Actions and split requirements files #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirements.txt has only the dependencies for running harmonica. The envs directory hosts files with requirements for particular tasks: building the wheel, running tests, checking style and building docs.
Verde is already a dependency present in requirements.txt
For building the docs we need pyproj and cartopy that are easier to install via conda.
santisoler
changed the title
WIP Replace conda for pip on Actions and split requirements files
Replace conda for pip on Actions and split requirements files
Nov 17, 2021
leouieda
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Left a comment on the pip cache part but I'm not sure if it's relevant.
Co-authored-by: Leonardo Uieda <leouieda@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
env
directory with somerequirements-*.txt
files, each onewith the specific dependencies to run certain tasks, like checking style,
running the test, publishing to PyPI and building the docs. The GitHub Actions
now use
pip
to install the dependencies instead of having to setup Minicondaand install them through
conda
. The only exception is the one that builds thedocs: we need
pyproj
andcartopy
to do so and they are easier to installthrough
conda
.Fixes #257
Reminders:
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
and the base__init__.py
file for the package.AUTHORS.md
file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.