-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to create a tesseroid layer #316
Conversation
…o tesseroid_layers
It returns the boundaries of the layer
Build the computation grid on a different set of points. Use meshgrid to build 2d versions of the original longitude and latitude arrays (don't regenerate it with vd.grid_coordinates).
Hello @leouieda and @santisoler I coded the function to calculate a teseroid layer and its gravity. I also created an example using Esaio's topography.
I know that I have a zero division, but I don't know where is the problem... It is my code that create wrong the layer or the tesseroid function to calculate the gravity. |
Sorry for not replying directly in this PR, @aguspesce. For the record, the zero division error was due to the fact that the forward modelling wasn't ignoring tesseroids with zero volume. You have already fixed it on #339. How is the status on this PR? Is it ready for review? |
Hello @santisoler. I've working in the test. If you like, you can review the example and the |
Hello @santisoler. I think that this PR is ready for your review |
Add a new mean_earth_radius fixture and use it as reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this @aguspesce! I left some minor suggestions. Check them out and don't hesitate to ask any question.
Co-authored-by: Santiago Soler <santiago.r.soler@gmail.com>
…o tesseroid_layers
@santisoler... when you have some time, take a look at the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aguspesce! A minor suggestions here. I'm committing them.
Add function that creates a tesseroid layer, similar to the prism layer. Create
an Xarray DataAccesor that makes available some methods to deal with the prism
layer, included one to compute the gravitational field generated by the whole
layer in a set of computation points. Add checks to avoid generating layers
with tesseroids that overlap around the earth. Add tests and a new gallery
example.
Fixes #83