-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default for window size in EquivalentSourcesGB #487
Conversation
…such that approximately 5000 data points are in each window.
|
…aising an error. Need to raise an error for data points less than and equal to 5e3.
Completed with @santisoler |
Update test to check for data points less than 5e3 and the associated warning.
This is starting to look great @indiauppal! I'm leaving a few ideas after the meeting we had today:
This is somewhat my personal wishlist for this PR, so feel free to assign me a few of these tasks if you want. As always, feel free to ask for help if you need it 🙂 Looking forward to see this merged! |
@indiauppal, I'm updating this branch after the fix I made for the failing Mac testing. Remember to run a |
Add India Uppal to the author list.
This reverts commit 14b1f65.
Check only 1 data and source window is created. Check if all sources and data points are inside the window.
Change the default value for the
window_size
in theEquivalentSourcesGB
constructor to"default"
: window size will be estimated to locate approximately 5000 data points in each window. Ifwindow_size="default"
and less than 5000 data points are used to fit the sources, a single window for all data and sources will be used. Check if the passed value ofwindow_size
is valid. Add a newwindow_size_
attribute to the class that is set after fitting the sources. Update docstrings and extend tests.Relevant issues/PRs:
Fixes #425