Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default n_splits=5 in scikit-learn KFold #143

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Set default n_splits=5 in scikit-learn KFold #143

merged 1 commit into from
Oct 11, 2018

Conversation

leouieda
Copy link
Member

@leouieda leouieda commented Oct 11, 2018

scikit-learn will change the default from 3 to 5 in an upcoming release.
Set the value to 5 now to prepare and make sure that future changes
don't affect us.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

scikit-learn will change the default from 3 to 5 in an upcoming release.
Set the value to 5 now to prepare and make sure that future changes
don't affect us.
@leouieda leouieda merged commit 1dcbc2a into master Oct 11, 2018
@leouieda leouieda deleted the nplits branch October 11, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant