Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the Jacobian for prediction #149

Merged
merged 7 commits into from
Oct 30, 2018
Merged

Don't use the Jacobian for prediction #149

merged 7 commits into from
Oct 30, 2018

Conversation

leouieda
Copy link
Member

All gridders create a Jacobian matrix to make predictions (using a dot product with the estimated parameters). This is very inefficient with regards to memory. Generating largeish grids requires a huge amount of RAM.

Replace these with a for loop summation. Accelerate them with numba to achieve the same performance. The pure Python version is slower than the dot product but at least it won't blow up memory.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

@leouieda leouieda merged commit 578bbd7 into master Oct 30, 2018
@leouieda leouieda deleted the predict branch October 30, 2018 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant