Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more functions part of the base API #156

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Make more functions part of the base API #156

merged 1 commit into from
Dec 11, 2018

Conversation

leouieda
Copy link
Member

n_1d_arrays, check_fit_input and least_squares are now part of the
verde.base API. These functions are needed for building new gridders.
Reorganize verde.base into a package and improve the documentation for
least_squares.

Fixes #154

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

`n_1d_arrays`, `check_fit_input` and `least_squares` are now part of the
`verde.base` API. These functions are needed for building new gridders.
Reorganize `verde.base` into a package and improve the documentation for
`least_squares`.

Fixes #154
@leouieda leouieda merged commit ed2729a into master Dec 11, 2018
@leouieda leouieda deleted the base branch December 11, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More functions in public API of verde. base
1 participant