Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Reset force coords when refitting splines #191

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

leouieda
Copy link
Member

Previously, the Spline set the force coordinates from the data
coordinates only the first time .fit was called. This means that when
fitting on different data, the spline would still use the old force
coordinates. Now, the spline will use the coordinates of the current
data passed to fit. This only affects cases where force_coords=None.
It's a slight change and only affects some of the scores for
cross-validation.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Previously, the `Spline` set the force coordinates from the data
coordinates only the first time `.fit` was called. This means that when
fitting on different data, the spline would still use the old force
coordinates. Now, the spline will use the coordinates of the current
data passed to `fit`. This only affects cases where `force_coords=None`.
It's a slight change and only affects some of the scores for
cross-validation.
@leouieda leouieda merged commit 4ec2508 into master Jun 14, 2019
@leouieda leouieda deleted the spline-reset branch June 14, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant