Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the optimal spline in SplineCV #219

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Expose the optimal spline in SplineCV #219

merged 1 commit into from
Jan 20, 2020

Conversation

leouieda
Copy link
Member

SplineCV was keeping the best Spline instance in SplineCV._best which
goes against the scikit-learn standard of storing estimated parameters
in variables ending in _. Change that to SplineCV.spline_ and add it
to the class attribute list.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

SplineCV was keeping the best Spline instance in `SplineCV._best` which
goes against the scikit-learn standard of storing estimated parameters
in variables ending in `_`. Change that to `SplineCV.spline_` and add it
to the class attribute list.
@leouieda leouieda requested a review from santisoler January 16, 2020 15:52
@leouieda leouieda added this to the v1.3.0 milestone Jan 16, 2020
@leouieda leouieda merged commit 4a7d086 into master Jan 20, 2020
@leouieda leouieda deleted the splinecv_best branch January 20, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants