Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pooch.os_cache and pkg_resources in datasets #220

Merged
merged 11 commits into from
Jan 20, 2020
Merged

Conversation

leouieda
Copy link
Member

With Pooch 0.7.0, the recommended way of loading the registry file is
with pkg_resources (see fatiando/pooch#120). It's also better to use
the default cache location so users can more easily clean up unused
files. Because this is system specific, add the verde.datasets.locate
function to return the cache folder location.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

With Pooch 0.7.0, the recommended way of loading the registry file is
with `pkg_resources` (see fatiando/pooch#120). It's also better to use
the default cache location so users can more easily clean up unused
files. Because this is system specific, add the `verde.datasets.locate`
function to return the cache folder location.
Using pkg_resources was not allowed before then.
This way we can copy the data to avoid downloads
@leouieda leouieda requested a review from santisoler January 16, 2020 16:42
@leouieda leouieda added this to the v1.3.0 milestone Jan 16, 2020
It's appended by Pooch
@leouieda
Copy link
Member Author

Fixed an issue in the CI (was setting the environment variable wrong). Will submit the same fix to Harmonica as well.

@leouieda leouieda merged commit 9564a2a into master Jan 20, 2020
@leouieda leouieda deleted the cache_location branch January 20, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants