Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GMT link in Baja bathymetry example #298

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Update GMT link in Baja bathymetry example #298

merged 3 commits into from
Nov 6, 2020

Conversation

Esteban82
Copy link
Member

I update the GMT link.

Is that from the example gallery 15? Maybe this could clarified.

I update the GMT link.

Is that from the example gallery 15? Maybe this could clarified.
@welcome
Copy link

welcome bot commented Nov 6, 2020

💖 Thanks for opening your first pull request! 💖

Please make sure you read the following:

  • Authorship Guidelines: Our rules for giving you credit for your contributions, including authorship on publications and Zenodo archives.
  • Contributing Guide: What the review process is like and our infrastructure for testing and documentation.
  • Code of Conduct: How we expect people to interact in our projects.

A few things to keep in mind:

  • Remember to run make format to make sure your code follows our style guide.
  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! ⭐

@leouieda
Copy link
Member

leouieda commented Nov 6, 2020

@Esteban82 thanks for the fix! This is used in several places in the GMT tutorial and gallery so not exclusively in "example 15". Plus, the number could change as we update the GMT docs. I included a mention that this is used the GMT gallery and tutorials.

Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging it in as soon as the CI finishes running 👍🏽

@leouieda leouieda changed the title Update baja_bathymetry.py Update GMT link in Baja bathymetry example Nov 6, 2020
@leouieda leouieda merged commit 943c6c8 into fatiando:master Nov 6, 2020
@welcome
Copy link

welcome bot commented Nov 6, 2020

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

If you would like to be added as a author on the Zenodo archive of the next release, make sure that you have added your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@Esteban82 Esteban82 deleted the patch-1 branch February 24, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants