Use a better Spline Green's function for small distances #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If distance is small change the Green's function to x(log(x**x)-1) which evaluates to the correct limit of 0. Deprecate the mindist parameters since it's no longer needed. Need to propagate changes to the SplineCV class now.
|
TODO:
|
Update the tests to not set mindist as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If distance is small change the Green's function to
x(log(x**x)-1)which evaluates to the correct limit of 0. Deprecate themindistparameter inSplineandSplineCVsince it's no longer needed. Remove use of this parameter from the documentation and presentdampingas the only configurable parameter for the splines.