-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropping non-dimensional coordinates in grid_to_table #441
Conversation
Add lines to search for extra coordinates and append the information into the list of coordinates and coordinates_name
💖 Thank you for opening your first pull request in this repository! 💖 A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @Souza-junior! Code looks good and the failed "style" check is not related to this (probably something updated in flake8) so you can ignore it.
All this needs now is a test. You can add one as a "doctest" here https://github.com/fatiando/verde/pull/441/files#diff-948da2a0e34f8cfb6c9d6b6498ec131890d1e637c8128eed5629fb5ce854dd7bR622
What I'd suggest is making a DataArray
with extra coordinates and seeing if they are picked up properly.
Hi @leouieda! I've added the test you asked for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @Souza-junior 👍🏾
🎉 Congrats on merging your first pull request and welcome to the team! 🎉 If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved. |
Merged! Thanks @Souza-junior 🎉 Please add yourself to the |
Add lines to search for extra coordinates and append the information into the list of coordinates and coordinates_name
Fixes #403
Relevant issues/PRs: