Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoTest never stops #1324

Closed
imroc opened this issue Jun 7, 2017 · 9 comments · Fixed by #1327
Closed

GoTest never stops #1324

imroc opened this issue Jun 7, 2017 · 9 comments · Fixed by #1327

Comments

@imroc
Copy link

imroc commented Jun 7, 2017

I uprade to v1.13 from v1.12 today, when I run :GoTest, it never stops. I have tried `:GoUpdateBinaries", it still the same. Is that a bug ?

  • vim version: 8.0.627
  • vim-go version: 1.13
  • go version: 1.8.3
@fatih
Copy link
Owner

fatih commented Jun 7, 2017

Can you give more detail what it means it never stops? couple of screenshots would be useful as well.

@imroc
Copy link
Author

imroc commented Jun 7, 2017

image

it never turn green

@vdemario
Copy link

vdemario commented Jun 8, 2017

The same is happening for me. If I run go test outside of vim it runs fine and passes but it never completes inside vim. I'm on 1.13 too.

One more thing that might be related. I have this in my .vimrc to compile tests without running them:

function! s:build_go_files()
  let l:file = expand('%')
  if l:file =~# '^\f\+_test\.go$'
    call go#cmd#Test(0, 1)
  elseif l:file =~# '^\f\+\.go$'
    call go#cmd#Install(0)
  endif
endfunction

which I took from here: https://github.com/fatih/vim-go-tutorial#test-it.

It's failing on 1.13 with this error:

Error detected while processing function <SNR>1_build_go_files:
line    3:
E117: Unknown function: go#cmd#Test

@vdemario
Copy link

vdemario commented Jun 8, 2017

I ran a git bisect and found out my problems start at commit 8f96994 but that led me to seeing go#cmd#Test was now go#test#Test.

However, at that point :GoTest was working. Another bisect indicates :GoTest stopped responding for me at d2ff39c.

Hope this helps.

fatih added a commit that referenced this issue Jun 8, 2017
This has regressed after the refactor. Because I had this enabled

```
let g:go_echo_command_info = 0
```

I was not able to see it.

fixes #1324
@fatih
Copy link
Owner

fatih commented Jun 8, 2017

Oh I see. This is because I've disabled echo via:

let g:go_echo_command_info = 0

This is fixed now. Please pull latest master.

@vdemario

I need to update the tutorial. Thanks for the heads up. The logic for :GoTestXXX commands have been moved to it's own file, which give us more flexibility going forward.

@vdemario
Copy link

vdemario commented Jun 8, 2017

Everything is working now, thanks @fatih.

@kjelle
Copy link

kjelle commented Aug 24, 2017

@fatih, could you update vimrc#L169 with go#test#Test, it still contains go#cmd#Test. Thanks.

@fatih
Copy link
Owner

fatih commented Aug 25, 2017

@kjelle where?

@kjelle
Copy link

kjelle commented Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants