:GoAddTags json,omitempty doesn't work

[arp242]

:GoAddTags is documented as:

If [option] is passed it'll either add a new tag with an option or will
modify existing tags. An example of adding omitempty to all json
fields would be:

  :GoAddTags json,omitempty

But that doesn't work; :GoAddTags json works fine, but :GoAddTags json,omitempty doesn't seem to do anything.

Not a recent breakage – I noticed this over a month ago (...just forgot to create issue).

[fatih]

This is by purpose like this (another discussion from last year: #985 (comment)) . To add an option, the tag needs to exist. If not it won't do anything. So to add the option you have the call these two:

:GoAddTags json
:GoAddTags json,omitempty

There is a reason I did this, but I still don't remember it unfortunately. I'm ok changing it back the behavior and seeing how it feels. The reason I've added it might come up in this case.

[arp242]

Hm, interesting. I made a quick patch (see above link) to pass both -add-tags and -add-options, and it seems to work in my testing(?)

If it doesn't work, then should at least clarify docs.

[fatih]

The tool works, the implementation in vim-go, as I know, won't work due the way I've implemented it initially. As I said, I don't remember the details.