GoCoverage broken in recent commit

[bradleyfalzon]

Actual behavior

Checkout f830d0d and try to use GoCoverage
Tests run, but coverage report doesn't appear.

See also PR #801

Expected behavior

Write here what you're expecting ...

Steps to reproduce:

Please create a reproducible case of your problem. Re produce it
with a minimal vimrc with all plugins disabled and only vim-go
enabled:

1. Open a go file that has tests
2. Checkout vim-go 1.6
3. Run GoCoverage
4. See coverage report
5. Checkout vim-go f830d0d
6. Run GoCoverage
7. No longer see coverage report

Configuration

Add here your current configuration and additional information that might be
useful, such as:

• vimrc you used to reproduce: NA
• vim version: 7.4
• vim-go version: Broken in f830d0d
• go version: go 1.6.2 linux/amd64

[bradleyfalzon]

So the issue, as I believe is due to https://github.com/fatih/vim-go/pull/801/files#diff-4

This line has recently changed from:

if !v:shell_error
    call go#coverage#overlay(l:tmpname)
endif

To:

if go#util#ShellError() != 0
    call go#coverage#overlay(l:tmpname)
endif

Which appears to be a typo, as the call to call is only executed when ShellError is non-zero - i.e. when there's an error.

The issue should be straight forward to fix in this case, but there's other logic errors in the change which may need to be reviewed (L93, maybe lint.vim on L67)

[bradleyfalzon]

@mattn - can you look over this and verify if this is a problem?

[mattn]

No

        exec '!go run ' . go#util#Shelljoin(go#tool#Files())

bang command should be set v:shell_errors always. maybe error occur at another part.

[bradleyfalzon]

Can you double check the logic in coverage.vim too, line 57 and 93: https://github.com/fatih/vim-go/pull/801/files#diff-4

[mattn]

Ah, sorry. My fix is bad. However I found some bug from your points. Thanks

[mattn]

strange. I can't reproduce it . do you install vimproc? or not?

[bradleyfalzon]

These are the steps I used to reproduce:

main.go

package main

import "fmt"

func main() {
    fmt.Println("done")
}

main_test.go

package main

import "testing"

func TestMain(t *testing.T) {
    main()
}

Checkout vim 1.6 in vim-go:

git checkout v1.6

vim main.go
:GoCoverage

You should then see the main func statements change to the colour green.

Close the file and checkout later commit:

git checkout f830d0dc170adfd7854532d571d2a0ecf818633e

vim main.go
:GoCoverage

The test should pass, but the statements should not change to the colour green this time.

The following patch then fixes the issue:

diff --git a/autoload/go/coverage.vim b/autoload/go/coverage.vim
index e19ba78..3dbc918 100644
--- a/autoload/go/coverage.vim
+++ b/autoload/go/coverage.vim
@@ -54,7 +54,7 @@ function! go#coverage#Buffer(bang, ...)
         return
     endif

-    if go#util#ShellError() != 0
+    if !go#util#ShellError()
         call go#coverage#overlay(l:tmpname)
     endif

[bradleyfalzon]

The proposed patch could easily be go#util#ShellError() == 0, I just used !go#util#ShellError() as an example.

[mattn]

Thanks figure out. Could you please try below.
put following line into above on

+    if !go#util#ShellError()

like

    let g:vimgo_debug = type(go#util#ShellError())
    if !go#util#ShellError()

And check with :echo g:vimgo_debug. What value returned?

[mattn]

Ah, one more. please check actual value of go#util#ShellError() also.

[mattn]

Hmm, I can't reproduce.

[bradleyfalzon]

Yes the test passes, but the coverage isn't shown.

I think you maybe debugging in the wrong area, look at the lines that changed:

From:

if !v:shell_error
    call go#coverage#overlay(l:tmpname)
endif

To:

if go#util#ShellError() != 0
    call go#coverage#overlay(l:tmpname)
endif

In the first case, the call to overlay only occurs when v:shell_error == 0, but in the second case, it's only called when v:shell_error == 1 - I believe this is the error.

[bradleyfalzon]

This is what should happen:

This is what happens:

Ignore the colour scheme I'm using, but that's the behaviour.