Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for GoDef call instead of go guru #887

Closed
sduchesneau opened this issue Jun 6, 2016 · 2 comments
Closed

add support for GoDef call instead of go guru #887

sduchesneau opened this issue Jun 6, 2016 · 2 comments

Comments

@sduchesneau
Copy link

Actual behavior

Go Guru is used for "GoDef" or "gd" to jump to definition by default.

Expected behavior

Have config parameter to use "godef", which is faster in most circumstances.

Steps to reproduce:

open a go project
put cursor on a function
type ":GoDef"
wait for go guru to do its thing....

Let me know if you need any more info!
Running both in parallel and getting the fastest result would also be awesome!
a variant like GoDefGuru for using one or the other would also be awesomer!

@marcosnils
Copy link

Is running both in parallel the best alternative?. Or maybe just allow to switch between one and the other one?

@fatih
Copy link
Owner

fatih commented Jun 6, 2016

I always prefer simple and well known solutions, so there will be no such parallel calling. Beside that currently Vim doesn't have a way to call things in parallel, even with vim 8.0 with it's async jobs, I think it's not worth to implement concurrent callings of the same problem just to gain milliseconds, because vim itself is already single threaded.

The feature is now merged to master. You can now use

let g:go_def_mode = 'godef'

To switch to godef. By default we still use guru as it covers more edge cases and I prefer stability over performance. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants