Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solarized theme incompatible with GoCoverage #960

Closed
blacksails opened this issue Jul 25, 2016 · 2 comments
Closed

Solarized theme incompatible with GoCoverage #960

blacksails opened this issue Jul 25, 2016 · 2 comments

Comments

@blacksails
Copy link

Actual behavior

I am using the popular solarized theme for vim together with item3 for mac.

My problem is that :GoCoverage highlights the text using bright colors which in the terminal theme is different shades of grey. In the following screenshot, line 10 should be green.

skaermbillede 2016-07-25 kl 11 03 15

Expected behavior

I would like to see either that vim-go recognizes that solarized is used or someway to edit the highlights that :GoCoverage is making.

Steps to reproduce:

  1. Install iterm on mac
  2. Install solarized iterm theme
  3. Install solarized vim theme
  4. Run :GoCoverage

Configuration

  • vim version: NVIM 0.1.4
  • vim-go version: newest
  • go version 1.6.2
fatih added a commit that referenced this issue Jul 26, 2016
This let's the user override those if they don't like it.

Closes: #960
@fatih
Copy link
Owner

fatih commented Jul 26, 2016

Hi @blacksails

I don't want to add solarized specific logic to vim-go. I've removed the gui parts and only changing the fg colors. You can also override them by adding the higlight definitions to your vimrc. Thanks.

@blacksails
Copy link
Author

@fatih ah that is sweet. Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants