Always use full path as statusline target directory #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parts of the code use go package dir relative to the current GOPATH as a target for statusline update message which leads to their messages not being displayed in the statusline (because it expects full path to the package). Fix this by always using full package path. Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
|
Thanks @pborzenkov. I've fixed it for other commands, seems like I've forgot them. Thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the code use go package dir relative to the current GOPATH
as a target for statusline update message which leads to their messages
not being displayed in the statusline (because it expects full path to
the package). Fix this by always using full package path.
Signed-off-by: Pavel Borzenkov pavel.borzenkov@gmail.com