Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix :GoBuild issues in neovim #1176

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Conversation

joshuarubin
Copy link
Contributor

  1. honor g:go_echo_command_info when dispatching builds in neovim
  2. fix :GoBuild error in neovim due to invalid jobcontrol handler function signatures (s:on_stdout, s:on_stderr)
  3. update statusline before and after go#jobcontrol#Spawn command is executed

also, as an aside, it looks like vim's job capability is utilized much more than neovim's job-control. it would be nice to abstract the differences and bring neovim up to parity again.

@joshuarubin
Copy link
Contributor Author

btw, (2) was caused by #1145
it removed the 3rd arg from the callback. here is the place that states that 3 args are required. my patch keeps the dict option though.
neovim/neovim#5763 (comment)

@joshuarubin
Copy link
Contributor Author

Any chance this can get merged?

@andviro
Copy link
Contributor

andviro commented Jan 24, 2017

Haha, missed this one. Did a similar job in #1183

@joshuarubin
Copy link
Contributor Author

Any update on this?

@fatih
Copy link
Owner

fatih commented Feb 2, 2017

@joshuarubin thanks for the PR. Sorry for my late response. I'm busy lately and was sick as well. I also went abroad to give a talk and thus didn't had any time to look at my open source projects. I'll check it out the following days, if not next week. For now please use it locally. Thanks.

@fatih
Copy link
Owner

fatih commented Feb 2, 2017

Thanks @joshuarubin this looks good.

also, as an aside, it looks like vim's job capability is utilized much more than neovim's job-control. it would be nice to abstract the differences and bring neovim up to parity again.

Agree, the reason is that Vim is supported more than Neovim right now. I'm open to improvements though for both platforms, unless they require complex changes. Eventually going forward, even if it takes some time, they both will have some feature parity.

@fatih fatih merged commit 3c5f09d into fatih:master Feb 2, 2017
@fatih fatih mentioned this pull request Feb 2, 2017
@joshuarubin joshuarubin deleted the neovim_go_build_fixes branch February 8, 2017 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants