Set the filename in the location-list #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At somepoint in the near past the location list seems to have broken as shown by fatih#1182. When comparing an older version of vim-go and master the difference seems to be due to not including the filename in the location list. According to the help page for `setqflist()` the filename should be added to the dictionary as the key `filename`. This lead me to pass the filename into the function that generates the individual lines of the location list and then set the file on each error.
|
Thanks @tarrant, this looks a good fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in the near past the location list seems to have broken as shown by #1182. When comparing an older version of vim-go and master the difference seems to be due to not including the filename in the location list.
According to the help page for
setqflist()the filename should be added to the dictionary as the keyfilename. This lead me to pass the filename into the function that generates the individual lines of the location list and then set the file on each error.This fixes the #1182 on my computer, but my knowledge of vim script is a bit question and would appreciate further verification.