Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add offset to goTypeConstructor. #1364

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Don't add offset to goTypeConstructor. #1364

merged 1 commit into from
Jul 22, 2017

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Jul 22, 2017

This is a regression from cfa9713. Previously the offset was needed since the
{ was matched as well. Now we don't match the { the offset means the last
character of the type won't be matched.

Fixes #1357

@arp242
Don't add offset to goTypeConstructor.
dd6e154 
This is a regression from cfa9713. Previously the offset was needed since the
`{` was matched as well. Now we don't match the `{` the offset means the last
character of the type won't be matched.

Fixes #1357
@fatih fatih merged commit d5979c9 into fatih:master Jul 22, 2017
@fatih
Copy link
Owner

fatih commented Jul 22, 2017

Thanks @Carpetsmoker 👍

@arp242 arp242 deleted the hl-type branch July 22, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arp242 @fatih