-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for denite.nvim about :GoDecls / :GoDeclsDir #1604
Conversation
4f560b0
to
165f384
Compare
Thanks @delphinus, I'm not sure this is something I would like to merge. Who is going to maintain the python script afterwards? We already have fzf, ctrlp and unite. |
My 2 cents is that this adding this won't affect any existing code or features. If you don't use denite.vim then you won't even know vim-go has a plugin thingy for it. If it ever breaks in the future we can just remove it if no one steps up to fix it. |
@Carpetsmoker what do you plan if a bug report comes for denite? |
Tell the submitter to fix it or learn to live with the bug :-) If it's a critical bug we can simply remove the denite.vim plugin if no one steps up. |
Sounds fair :) |
doc/vim-go.txt
Outdated
:Unite decls[:file or dir] | ||
:Denite decls[:file or dir] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:Denite decls dir
doesn't seem to work? I get [denite] NameError: Source "dir" is not found.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
denite needs options :
separated. And the file or dir
is some illustration, so users should supply the real path.
:Denite decls:~/.go/src/github.com/golang/appengine
" relative path also available. same meaning if you are in ~/.go/src/github.com
:Denite decls:golang/appengine
The description is a bit obscure maybe, but I followed descriptions already written about unite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right. I normally don't use this plugin so excuse my ignorance. I've tweaked the documentation a bit, which makes it a bit clearer I think.
doc/vim-go.txt
Outdated
Only useful if `ctrlp.vim`, `unite.vim`, `denite.nvim` or `fzf` are installed. | ||
This sets which declarations to show for |:GoDecls| (`ctrp.vim`), | ||
|unite-decls| (`unite.vim`) and |denite-decls| (`denite.nvim`). It is a Comma | ||
delimited list Possible options are: {func,type}. The default is: > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor, but missing full stop or semicolon before "Possible" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
After testing I have Can just add |
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
=========================================
Coverage ? 14.78%
=========================================
Files ? 53
Lines ? 4152
Branches ? 0
=========================================
Hits ? 614
Misses ? 3538
Partials ? 0
Continue to review full report at Codecov.
|
Added to |
Can we include this information in the doc? I assume Vim also needs to be compiled with +python right? |
Added requirements for denite. 👍 |
3c5f928
to
cd8c409
Compare
Thanks! 👍 |
denite.nvim is the successor of unite.vim. This PR enables
:GoDecls
&:GoDeclsDir
features by denite as same as unite in #1391.denite is written for NeoVim / Vim 8 and it uses more progressive features than unite. The expansions of denite must be written in Python3.
:Denite decls