Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for denite.nvim about :GoDecls / :GoDeclsDir #1604

Merged
merged 7 commits into from
Dec 10, 2017

Conversation

delphinus
Copy link
Contributor

denite.nvim is the successor of unite.vim. This PR enables :GoDecls & :GoDeclsDir features by denite as same as unite in #1391.

" available below as same as :Unite decls
:Denite decls
:Denite decls:foo.go
:Denite decls:foo/bar

denite is written for NeoVim / Vim 8 and it uses more progressive features than unite. The expansions of denite must be written in Python3.

:Denite decls
2017-12-07 23 33 25

@fatih
Copy link
Owner

fatih commented Dec 7, 2017

Thanks @delphinus,

I'm not sure this is something I would like to merge. Who is going to maintain the python script afterwards? We already have fzf, ctrlp and unite.

@arp242
Copy link
Contributor

arp242 commented Dec 7, 2017

My 2 cents is that this adding this won't affect any existing code or features. If you don't use denite.vim then you won't even know vim-go has a plugin thingy for it. If it ever breaks in the future we can just remove it if no one steps up to fix it.

@fatih
Copy link
Owner

fatih commented Dec 7, 2017

@Carpetsmoker what do you plan if a bug report comes for denite?

@arp242
Copy link
Contributor

arp242 commented Dec 7, 2017

Tell the submitter to fix it or learn to live with the bug :-) If it's a critical bug we can simply remove the denite.vim plugin if no one steps up.

@fatih
Copy link
Owner

fatih commented Dec 7, 2017

Sounds fair :)

doc/vim-go.txt Outdated
:Unite decls[:file or dir]
:Denite decls[:file or dir]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:Denite decls dir doesn't seem to work? I get [denite] NameError: Source "dir" is not found..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

denite needs options : separated. And the file or dir is some illustration, so users should supply the real path.

:Denite decls:~/.go/src/github.com/golang/appengine
" relative path also available. same meaning if you are in ~/.go/src/github.com
:Denite decls:golang/appengine

The description is a bit obscure maybe, but I followed descriptions already written about unite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. I normally don't use this plugin so excuse my ignorance. I've tweaked the documentation a bit, which makes it a bit clearer I think.

doc/vim-go.txt Outdated
Only useful if `ctrlp.vim`, `unite.vim`, `denite.nvim` or `fzf` are installed.
This sets which declarations to show for |:GoDecls| (`ctrp.vim`),
|unite-decls| (`unite.vim`) and |denite-decls| (`denite.nvim`). It is a Comma
delimited list Possible options are: {func,type}. The default is: >
Copy link
Contributor

@arp242 arp242 Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, but missing full stop or semicolon before "Possible" here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arp242
Copy link
Contributor

arp242 commented Dec 7, 2017

After testing I have rplugin/python3/denite/source/__pycache__/decls.cpython-36.pyc as an untracked file in git. Would be a good idea to add that to gitignore to prevent it from being accidentally checked in.

Can just add *.pyc; that will cover this and all future cases.

@codecov-io
Copy link

codecov-io commented Dec 8, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@21c2629). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1604   +/-   ##
=========================================
  Coverage          ?   14.78%           
=========================================
  Files             ?       53           
  Lines             ?     4152           
  Branches          ?        0           
=========================================
  Hits              ?      614           
  Misses            ?     3538           
  Partials          ?        0
Flag Coverage Δ
#nvim 5.05% <ø> (?)
#vim74 14.71% <ø> (?)
#vim80 14.47% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c2629...cd8c409. Read the comment docs.

@delphinus
Copy link
Contributor Author

Added to .gitignore. check it. 👍

@fatih
Copy link
Owner

fatih commented Dec 9, 2017

The expansions of denite must be written in Python3.

Can we include this information in the doc? I assume Vim also needs to be compiled with +python right?

@delphinus
Copy link
Contributor Author

Added requirements for denite. 👍

@arp242 arp242 merged commit 7904a27 into fatih:master Dec 10, 2017
@arp242
Copy link
Contributor

arp242 commented Dec 10, 2017

Thanks! 👍

@delphinus delphinus deleted the feature/denite-decls branch December 10, 2017 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants