Fix ftdetect #1645
Merged
Fix ftdetect #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not use augroup in ftdetect script (see `:help ftdetect`)
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
+ Coverage 17.77% 19.21% +1.43%
==========================================
Files 57 53 -4
Lines 4770 4153 -617
==========================================
- Hits 848 798 -50
+ Misses 3922 3355 -567
Continue to review full report at Codecov.
|
|
Thanks @ichizok This is from the help doc I've looked at the Git history and the change was introduced by @Carpetsmoker. I assume you must be right (according to the doc) but let me ping him as well. |
|
Yeah, this change seems okay 👍 I didn't know that ftdetect already wrapped stuff in an augroup. |
amadeus
pushed a commit
to pangloss/vim-javascript
that referenced
this pull request
Aug 14, 2019
This is from the help doc :help ftdetect: Note that there is no "augroup" command, this has already been done when sourcing your file. You could also use the pattern "*" and then check the contents of the file to recognize it. Reference: Vimjas/vint#264 fatih/vim-go#1645
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sourcing
ftdetect/*.vim(in$VIMRUNTIME/filetype.vim),augroup filetypedetectis already set.Thus using
augroupin ftdetect script, autocmds in gofiletype.vim and in other ftdetect scripts sourced after gofiletype.vim do not belong toaugroup filetypedetect.This makes some behaviors about filetype (e.g.
:filetype off) broken.