Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset current directory after each test
use go list to get import path via go#package#FromPath
fix uses of g:go_debug_commands
doesn't have to be set before the read.
value.
Shutdown and detach from delve correctly
Use a single connection to delve to simplify detaching properly. The
previous implementation was making a connection to delve for each
request and was never closing any of them. Instead, create a single
connection to delve and reuse it for each rpc call. This allows vim-go
to not have to pass
--accept-multiclient
, which in turn shutsdowndelve when detach is called.
As part of this work,
call_jsonrpc
was refactored to not deal withcallbacks explicitly. Because Neovim requires a callback to get data
from a socket, the
on_data
callback was moved intoout_cb
andimproved to deal with the edge cases that Neovim has with regard to
partial messages.
delay changing working directory for dlv test
Delay changing the working directory for debugging tests only if the
package to be debugged could be determined.
Return early and show an error if the package could not be determined.
add debug tests
Add debug tests to ensure that :GoDebugStart and :GoDebugStop work as
expected with no arguments, a relative package and package specified
with its full import path
The test package source file is in a package named debugmain instead of
following the usual pattern (e.g. debug), because delve seems to choke
pretty hard on when the package being debugged is named debug...