change to appropriate dir before quickfix parse #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
requested changes
Jul 14, 2019
autoload/go/term.vim
Outdated
| @@ -140,6 +145,9 @@ function! s:on_exit(job_id, exit_status, event) dict abort | |||
|
|
|||
| call win_gotoid(self.winid) | |||
| call go#list#JumpToFirst(l:listtype) | |||
|
|
|||
| " change back to original working directory before this method start | |||
| cd - | |||
There was a problem hiding this comment.
This won't do the right thing when lcd was used instead of cd. Would you be willing to modify this PR to follow the usual pattern that is used in vim-go (see go#term#newmdoe at https://github.com/fatih/vim-go/blob/master/autoload/go/term.vim#L28-L31 and https://github.com/fatih/vim-go/blob/master/autoload/go/term.vim#L54) for this pattern?
There was a problem hiding this comment.
@bhcleek totally makes sense, just pushed a commit to update with that pattern.
ldelossa
force-pushed
the
fix-test-quickfix-path
branch
2 times, most recently
from
88391ec
to
348eff9
Compare
|
@bhcleek looks like this failed, but only for vim7.4 - if I'm reading this correctly it's because CodeCov could not be reached? https://travis-ci.org/fatih/vim-go/jobs/558716774 |
ldelossa
force-pushed
the
fix-test-quickfix-path
branch
from
348eff9
to
84381f9
Compare
|
Thanks. |
bhcleek
added a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2400
We now CD into the same directory builds and test are ran before populating the QuickFix or LocationList items. This fixes a problem where the hyperlinked path in the quickfix menu pointed to "./file_name" and your vim current directory is not in "./"