lint: homogenize code quality tool calls #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use go#util#ExecInDir() when running go vet. * Make the progress message when starting go vet consistent with errcheck's similiar progress message. * Call go#cmd#autowrite() when starting go#lint#Errcheck to either write the buffers that have modifications when 'autowrite' or 'autowriteall' are set or display a message if neither of those options are set, because errcheck only analyzes files on disk. * chagne the error message that's displayed when the package name cannot be determined to avoid implying that the package must be in GOPATH when the user is operating in module aware mode. * Do not echo the start of errcheck progress if g:go_echo_command_info is cleared. * disable g:go_echo_command_info when running tests to avoid screen clutter when tests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint: homogenize vet and errcheck handling
errcheck's similiar progress message.
the buffers that have modifications when 'autowrite' or 'autowriteall'
are set or display a message if neither of those options are set,
because errcheck only analyzes files on disk.
be determined to avoid implying that the package must be in GOPATH
when the user is operating in module aware mode.
is cleared.
clutter when tests fail.
lint: set progress and statusline for consistently