Add syntax for 'retract' directive in go.mod #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retract directive is new with Go 1.16. https://golang.org/ref/mod#go-mod-file-retract
|
#3162 exists, but my implementation supports the block syntax. |
carnott-snap
reviewed
Mar 8, 2021
| syntax match gomodVersionRangeBracket "\[" contained | ||
| syntax match gomodVersionRangeBracket "\]" contained | ||
| highlight default link gomodVersionRangeBracket Operator | ||
| syntax match gomodVersionRangeSeparator "," contained |
There was a problem hiding this comment.
to be consistent with source, we probably should not highlight the ,s
carnott-snap
reviewed
Mar 8, 2021
| syntax match gomodVersionRangeSeparator "," contained | ||
| highlight default link gomodVersionRangeSeparator Operator | ||
|
|
||
|
|
There was a problem hiding this comment.
extra new line?
Suggested change
carnott-snap
approved these changes
Mar 8, 2021
bhcleek
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
This looks good. Thank you.
@carnott-snap is right on the comment regarding the comma and extra newline. Feel free to change those if you want before I merge this. Otherwise, I'll merge it soon and make the changes myself.
bhcleek
added a commit
that referenced
this pull request
Mar 10, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retract directive is new with Go 1.16.
https://golang.org/ref/mod#go-mod-file-retract
I'm not an expert at Vim syntax, so please review carefully.
Cc: @carnott-snap @bhcleek @rhysd