Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to using lcd when changing directory. #3299

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Revert to using lcd when changing directory. #3299

merged 1 commit into from
Oct 4, 2021

Conversation

ixru
Copy link

@ixru ixru commented Oct 4, 2021

Don't know if there was some other reason for the change. Changing it back to what it was originally seems to work.

bhcleek
bhcleek requested changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@bhcleek bhcleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you change this to fix the issue by using execute printf('%s %s', cd, fnameescape(a:dir)) instead of reverting?

@bhcleek
Copy link
Collaborator

bhcleek commented Oct 4, 2021

Thank you

@bhcleek bhcleek merged commit 53fe9fe into fatih:master Oct 4, 2021
bhcleek added a commit that referenced this pull request Oct 4, 2021
@bhcleek
update CHANGELOG.md for #3299
c505eda
@bhcleek bhcleek added this to the vim-go 1.26 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhcleek bhcleek bhcleek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vim-go 1.26
Development

Successfully merging this pull request may close these issues.
2 participants
@ixru @bhcleek