Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard quickfix errors when quickfix doesn't locate a file to jump to #547

Merged
merged 1 commit into from
Oct 19, 2015
Merged

Discard quickfix errors when quickfix doesn't locate a file to jump to #547

merged 1 commit into from
Oct 19, 2015

Commits on Oct 19, 2015

  1. Drop bad filenames from qflist in GoRun

    Fix for #287
    
    When a line of output is parsed incorrectly as an error message, the
    quickfix feature of Vim creates an unlisted buffer containing a bad
    filename. On jumping to this item with `cc`, a blank, unsaved file is
    opened in the active window. It is never useful to jump to a nonexistent
    file from quickfix and users unused to navigating buffers in Vim may
    have trouble figuring out what happened.
    
    Since the line of output that was parsed may still be an important error
    message, rather than silently dropping it from the quickfix window, echo
    a message for each bad filename dropped in this way. (Known issue: If
    `cc 1` jumps to a new buffer immediately, the message `"{filename}"
    {linenumber}L, {colnumber}C` hides the drop messages.)
    
    While looping through qflist items, avoid checking the same `filename`
    more than once by remembering the return values of previous calls to
    `filereadable` during the current execution of `:GoRun`.
    
    Add comments to explain the compiler errorformat strings. Patterns must
    be appended in separate statements in order to use inline comments here.
    AlexHuthCARB committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    8bc21fe View commit details
    Browse the repository at this point in the history