Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw! after running Go program from Vim #743

Closed
wants to merge 1 commit into from

Conversation

gypsydave5
Copy link

Hi - hope you don't mind the pull request (even though it's really small!) - I've just been playing around with the plugin tonight (having a great time using it and learning Go), but I'd noticed that my vim session was coming up black after I'd run the (tiny) Go program I was writing.

I've thrown a redraw! at the end of the run command and it seems to fix it for me locally - thought I'd make you a small pull request before I went to bed.

@nerakhon
Copy link

nerakhon commented Mar 1, 2016

I tested this and it solves the problem in my case.

@nerakhon
Copy link

nerakhon commented Mar 1, 2016

Actually I was thinking about this and it seems to me a better result would be if after the GoRun the output was waiting for keypress like if running via ! go run %, but that's probably not a subject matter of this bug and an enhancement.

@gypsydave5
Copy link
Author

I was thinking about that too @nerakhon - came to the conclusion just now that it would be nice if we could redirect the output of run into a scratch buffer... but like you say, that's more of a different feature.

bhcleek added a commit to bhcleek/vim-go that referenced this pull request Mar 3, 2016
Fixes regression introduced in fatih#700, as documented on fatih#739 and fatih#743.
@bhcleek bhcleek mentioned this pull request Mar 3, 2016
@bhcleek
Copy link
Collaborator

bhcleek commented Mar 3, 2016

@nerakhon I think your suggestion about behaving just like !go run % is exactly right; that's what vim-go used to do before I messed it up in #700. #748 should restore the previous behavior of showing the output and prompting the user to hit enter before coming back to the buffer.

@fatih
Copy link
Owner

fatih commented Mar 3, 2016

I think this is now fixed with #748 fixes via @bhcleek . Can you test it please @gypsydave5 ? We don't need to call redraw anymore as the underlying fix is resolved.

@gypsydave5
Copy link
Author

Ah nice one! Definite fix - thanks 👍 🎆

@gypsydave5 gypsydave5 closed this Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants