Properly use exepath for CheckBinPath #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized that #839 had issues with this, it's because they were running an older patch of vim 7.4 that doesn't have |
| @@ -115,7 +115,8 @@ function! go#fmt#Format(withGoimport) | |||
|
|
|||
| if fmt_command == "goimports" | |||
| if !exists('b:goimports_vendor_compatible') | |||
| let out = go#util#System("goimports --help") | |||
| let binpath = go#path#CheckBinPath("goimports") | |||
| let out = go#util#System(binpath . " --help") | |||
There was a problem hiding this comment.
Please remove this as we check above already.
There was a problem hiding this comment.
Pushed a fix for this.
|
@fatih thoughts? |
|
fwiw, I manually applied the patch and it fixed things for me. |
|
Thanks @luan 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#823 added this the wrong way, it was reverted back on 9f0cf00 but still not achieving the right functionality.
This uses it properly now, also adding it to how we lookup goimports for srcdir support.