Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor faucet_event_client into python_lib #938

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

anurag6
Copy link
Collaborator

@anurag6 anurag6 commented Dec 16, 2021

Refactoring faucet_event_client into python_lib to allow multiple components other than daq(like device_coupler) to access it.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #938 (09cd971) into master (052db4b) will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   82.51%   82.59%   +0.07%     
==========================================
  Files          46       45       -1     
  Lines        5862     5693     -169     
==========================================
- Hits         4837     4702     -135     
+ Misses       1025      991      -34     
Flag Coverage Δ
ata 62.80% <50.00%> (+0.17%) ⬆️
aux 67.82% <50.00%> (-0.43%) ⬇️
base 65.99% <50.00%> (-0.48%) ⬇️
dhcp 67.12% <50.00%> (-0.38%) ⬇️
many 66.82% <50.00%> (-0.39%) ⬇️
mud 71.80% <50.00%> (-0.35%) ⬇️
switch 67.35% <50.00%> (-0.44%) ⬇️
topo 66.23% <50.00%> (-0.28%) ⬇️
unit 32.88% <25.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/forchestrator.py 0.00% <0.00%> (ø)
daq/runner.py 85.44% <100.00%> (-0.11%) ⬇️
daq/traffic_analyzer.py 86.50% <0.00%> (-3.18%) ⬇️
daq/topology.py 95.85% <0.00%> (-0.16%) ⬇️
python_lib/faucet_event_client.py
daq/host.py 91.35% <0.00%> (+0.28%) ⬆️
daq/tcpdump_helper.py 80.95% <0.00%> (+2.38%) ⬆️
daq/stream_monitor.py 90.08% <0.00%> (+2.47%) ⬆️
daq/varz_state_collector.py 50.60% <0.00%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052db4b...09cd971. Read the comment docs.

@anurag6 anurag6 merged commit fde760a into faucetsdn:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants