Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Event Feed StartTS #182

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Event Feed StartTS #182

merged 2 commits into from
Nov 11, 2024

Conversation

cynicaljoy
Copy link
Contributor

BT-5308

Description

Event Feeds StartTS Updates

Motivation and context

  • Fix bug with options being carried over and causing bad requests
  • Allow consumers to use time.Time for a more natural experience.

How was the change tested?

Updated integ test

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cynicaljoy cynicaljoy merged commit 57ff77a into main Nov 11, 2024
5 checks passed
@cynicaljoy cynicaljoy deleted the event-feed-ts-update branch November 11, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnwpedro pnwpedro pnwpedro approved these changes

@adambollen adambollen Awaiting requested review from adambollen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cynicaljoy @pnwpedro