Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename StartTS option methods #185

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: Rename StartTS option methods #185

merged 1 commit into from
Nov 12, 2024

Conversation

cynicaljoy
Copy link
Contributor

BT-5313

Description

Rename the option methods that set StartTs for Event Streams and Feeds

Motivation and context

Allow a more native UX with time.Time

How was the change tested?

Updated integ tests

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cynicaljoy cynicaljoy merged commit e5021d3 into main Nov 12, 2024
5 checks passed
@cynicaljoy cynicaljoy deleted the startts-refactor branch November 12, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants