Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkstyle issues in com.fauna.mapping.* #174

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix checkstyle issues in com.fauna.mapping.* #174

merged 2 commits into from
Nov 8, 2024

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Nov 7, 2024

Description

  • Add javadocs to all com.fauna.mapping.* classes
  • Apply non-formatting checkstyle fixes to the same

Motivation and context

BT-5258

Consistency and documentation!

How was the change tested?

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jrodewig
jrodewig reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some suggestions, but they're mostly non-blocking nits. Feel free to disregard as you see fit.

src/main/java/com/fauna/mapping/FieldInfo.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/mapping/FieldType.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/mapping/FieldType.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/mapping/FieldType.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/mapping/FieldType.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/mapping/FieldType.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/mapping/FieldType.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/mapping/package-info.java Outdated Show resolved Hide resolved
@pnwpedro @jrodewig
Apply suggestions from code review
db9a4a3 
Co-authored-by: James Rodewig <james.rodewig@fauna.com>
@pnwpedro pnwpedro requested a review from jrodewig November 8, 2024 17:04
@pnwpedro pnwpedro merged commit 66c59d7 into main Nov 8, 2024
1 check passed
@pnwpedro pnwpedro deleted the com.fauna.mapping-javadocs branch November 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@findgriffin findgriffin Awaiting requested review from findgriffin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnwpedro @jrodewig