Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unmaterialized sets in PageCodec #183

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Nov 12, 2024

Description

Handle unmaterialized sets in PageCodec.

Motivation and context

BT-5310

We fixed this a while ago in the UTF8FaunaParser, but I forgot to include changes in the PageCodec as well.

How was the change tested?

Added a unit test.

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@findgriffin findgriffin merged commit 953f8e4 into main Nov 12, 2024
1 check passed
@findgriffin findgriffin deleted the decode-unmaterialized-sets branch November 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants