Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPX read timeout is set to infinite by default #122

Closed
ryancausey opened this issue May 25, 2023 · 1 comment
Closed

HTTPX read timeout is set to infinite by default #122

ryancausey opened this issue May 25, 2023 · 1 comment
Assignees
Labels
GA Required This must be resolved for GA acceptance

Comments

@ryancausey
Copy link

I traced a hung client down to this following line where it appears if no timeouts are passed, the HTTP read timeout is set to None. This, as far as I can tell from the HTTPX docs, means it will never time out.

Line: https://github.com/fauna/fauna-python/blob/main/fauna/client/client.py#LL123C18-L123C18
HTTPX timeout docs: https://www.python-httpx.org/advanced/#timeout-configuration
FQLv10 code that produced the hung client: https://forums.fauna.com/t/fqlv10-comparison-of-objects-never-completes/3652

@ptpaterson
Copy link
Contributor

Thanks for the issue, repro information, and bringing this to our attention!

More work is scheduled for the Python driver before GA. An internal issue has been created to track this: BT-3922

@ptpaterson ptpaterson added the GA Required This must be resolved for GA acceptance label May 30, 2023
@cynicaljoy cynicaljoy self-assigned this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GA Required This must be resolved for GA acceptance
Projects
None yet
Development

No branches or pull requests

3 participants